Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type 'UIApplication' does not conform to protocol 'TikTokURLOpener' (Xcode 16 beta 3) #40

Closed
Frizlab opened this issue Jul 9, 2024 · 16 comments

Comments

@Frizlab
Copy link

Frizlab commented Jul 9, 2024

The package does not compile on Xcode 16 beta 3 (and 4).

The UIApplication class is made to conform to TikTokURLOpener in the package (which is an excessively bad practice, mainly due to the error we get now).

It used to work because UIApplication implemented the function open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey : Any], completionHandler completion: ((Bool) -> Void)?). Now the function’s signature has changed slightly; it is open(_ url: URL, options: [UIApplication.OpenExternalURLOptionsKey : Any], completionHandler completion: (@Sendable @MainActor (Bool) -> Void)?) so it does not work anymore.

Please don’t make external types conform to internal protocols, it is never a good idea.

@larryonoff
Copy link

I have the same issue

@AustinConlon
Copy link

Reproducible on Xcode 16 beta 4 as well.

@Frizlab
Copy link
Author

Frizlab commented Jul 23, 2024

@AustinConlon Oh yeah it’s not going away. TikTok must fix their SDK. It’s not complicated but must be done.

@wendyliga
Copy link
Member

this PR should fix the issue #41

@Kharauzov
Copy link

This issue is still actual for anyone who wants to run his project on Xcode 16 Beta.
Are there any updates to resolve this blocker?

@adamvnovak
Copy link

Stil an issue for me.

@AustinConlon
Copy link

Since the Xcode 16 RC is now out, it would be great to see this prioritized.

@SimpleApp
Copy link

Xcode 16 is now on the app store. Meaning the SDK officially doesn't work anymore ?

@WineKai
Copy link

WineKai commented Sep 18, 2024

When will this be fixed?

@andrzli
Copy link

andrzli commented Sep 24, 2024

Having the same issue

@Frizlab
Copy link
Author

Frizlab commented Sep 24, 2024

Version 2.5 fixes the issue guys…

@tetkosimi
Copy link

It seems that version 2.5.0 has not been published or at least not available in CocoaPods.
https://github.com/CocoaPods/Specs/tree/master/Specs/a/e/4/TikTokOpenSDKCore
https://github.com/CocoaPods/Specs/tree/master/Specs/b/3/5/TikTokOpenAuthSDK

@Frizlab
Copy link
Author

Frizlab commented Sep 25, 2024

It is published and it works via SPM https://github.com/tiktok/tiktok-opensdk-ios/releases/tag/v2.5.0
I don’t know about cocoa pods (but I don’t use it).

@Frizlab Frizlab closed this as completed Sep 25, 2024
@JW-chenjingwei
Copy link

SPM only suport swift,but not suport cocoapods,please publish whith cocoapods,thanks

@Frizlab
Copy link
Author

Frizlab commented Sep 25, 2024

I ain’t the maintainer. My original issue was fixed; you should open a new one if you need it.

@JW-chenjingwei
Copy link

JW-chenjingwei commented Sep 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests