Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance MonitorPageNetwork function #1

Open
hawarir opened this issue Jul 19, 2019 · 0 comments
Open

Enhance MonitorPageNetwork function #1

hawarir opened this issue Jul 19, 2019 · 0 comments

Comments

@hawarir
Copy link
Contributor

hawarir commented Jul 19, 2019

I just realised from the doc, ListenTarget runs its function synchronously:
"Note that the function is called synchronously when handling events. The function should avoid blocking at all costs. For example, any Actions must be run via a separate goroutine."

https://godoc.org/github.com/chromedp/chromedp#ListenTarget

We'll need to takeout the writer from inside the function and preferably using goroutine to run the function logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant