Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category view, options are not respected #49

Open
Spb8Lighting opened this issue Aug 7, 2016 · 3 comments
Open

Category view, options are not respected #49

Spb8Lighting opened this issue Aug 7, 2016 · 3 comments
Labels
Milestone

Comments

@Spb8Lighting
Copy link

Spb8Lighting commented Aug 7, 2016

Hello,

I have an issue when the forum is a category, the options are not respected (the one who permits to put text instead of an icon).

I think it is because we can't set option on this kind of forum, and so, with topic coming from sub-forum, we have default display option.

This issue is visible there : http://forum.spb8.lighting/viewforum.php?f=3

And the right result can be seem in the related sub-forum : http://forum.spb8.lighting/viewforum.php?f=8

Many thanks for your extension, it is very useful :)

PhpBB v3.1.9
TopicSolved v2.2.0

@tierra
Copy link
Owner

tierra commented Aug 7, 2016

Interesting, I don't think I considered this case, but it's definitely an oversight.

Assuming you had different display options for a parent forum, would you expect each topic to use the display settings of the child forum it's in (even though it's being displayed in a parent forum), or for all sub-forum topics displayed in the parent to adopt the parent's display settings?

@Spb8Lighting
Copy link
Author

I think it's better that parent option does not applies its own.

As the right content has been set on the child, it should reuse it as it given.

For my usage of topic solved, but also for search/sold sub-forum it will perfectly fit my needs.

Thanks for your quick answer, much appreciated :)

@tierra tierra added the bug label Aug 8, 2016
@tierra tierra added this to the 2.3.0 milestone Aug 8, 2016
@MikkCZ
Copy link

MikkCZ commented Mar 30, 2017

What is the current status of the solution? I see this as last issue for 2.3.0 milestone, which should add support for phpBB 3.2 I am using.

@tierra tierra modified the milestones: 2.3.0, 2.4.0 Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants