-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect parsing Auth results DKIM #45
Labels
bug
Something isn't working
Comments
moorereason
added a commit
to moorereason/dmarc-report-converter
that referenced
this issue
Apr 13, 2024
The DMARC spec allows for zero or more DKIM results and one or more SPF results. Prior to this commit, we only allowed for a single result for each type. Update the dmarc.AuthResults struct to use a slice for each type. For reference, see the definition of AuthResultType in Appendix C of RFC 7489. This change in the data model required updates to the Go templates. The two HTML templates are almost exactly the same, so pull the common body out into a separate const variable to ease maintenance. Fixes tierpod#45
Hi @incous, I merged PR that should fix this problem yesterday. I'm going to make a new release soon. It would be nice if you could build dmart-report-converter from master branch and do some tests. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It happen for not parsing the correct DKIM Auth Result as the message may got multiple DKIM signatures.
Example:
I got this, and the parsed HTML show this entry as DKIM auth fail, SPF auth pass, but DMARC still pass for DKIM & SPF
The text was updated successfully, but these errors were encountered: