Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check table_path() approach with backends #1453

Closed
hadley opened this issue Feb 15, 2024 · 4 comments · Fixed by #1467
Closed

Check table_path() approach with backends #1453

hadley opened this issue Feb 15, 2024 · 4 comments · Fixed by #1467
Milestone

Comments

@hadley
Copy link
Member

hadley commented Feb 15, 2024

And figure out what fixes are needed.

@hadley hadley added this to the 2.4.1 milestone Feb 15, 2024
@hadley
Copy link
Member Author

hadley commented Feb 20, 2024

@hadley
Copy link
Member Author

hadley commented Feb 20, 2024

revdep failures that look related:

Also need to work through packages that use dbplyr_table_ident:

@hadley
Copy link
Member Author

hadley commented Feb 21, 2024

cc @mgirlich can you think of any other ways to find packages that might be affected? Otherwise I now feel pretty confident that the existing API is adequate and we can close this issue.

@mgirlich
Copy link
Collaborator

I also looked at the PRs you created and I agree that the exported API looks good. For finding affected packages I also relied on revdep, so I don't know any other way to find affected packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants