Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all models with allow_sparse_x works with sparse data #1220

Open
EmilHvitfeldt opened this issue Nov 15, 2024 · 0 comments
Open

Make sure all models with allow_sparse_x works with sparse data #1220

EmilHvitfeldt opened this issue Nov 15, 2024 · 0 comments
Labels
feature a feature request or enhancement

Comments

@EmilHvitfeldt
Copy link
Member

We can do this in mocked tests, properly in extratests.

Just because allow_sparse_x has been set, doesn't mean we haven't accidentally called as.matrix() on the data before it reached the model engine. This is a triple check to make sure

go through all extension packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EmilHvitfeldt