Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "optimal" from dials::values_weight_func #370

Open
topepo opened this issue Jan 29, 2025 · 0 comments · May be fixed by #372
Open

Remove "optimal" from dials::values_weight_func #370

topepo opened this issue Jan 29, 2025 · 0 comments · May be fixed by #372

Comments

@topepo
Copy link
Member

topepo commented Jan 29, 2025

In kknn::train.kknn(), the "optimal" value is found by optimizing the holdout set error. When we invoke that function, we don't have the holdout data, so we give it the training set (since we need to give it something).

It would be better to remove it than to keep it in and let tune_*() choose it because it had the best resubstitution error.

@hfrick hfrick linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant