We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I was checking the BagOne class, and on this line:
BagOne
OpenNRE/opennre/model/bag_one.py
Line 46 in 0acd945
the method sentence_encoder.tokenizer was being used in this way:
sentence_encoder.tokenizer
token, pos1, pos2, mask = self.sentence_encoder.tokenize(item)
However, aren't the position of pos1 and masks flipped? And, what if the masks entry is not being returned? E.g. see here:
pos1
masks
Different order of the returned values: https://github.com/thunlp/OpenNRE/blob/master/opennre/encoder/bert_encoder.py#L215
No masks returned:
OpenNRE/opennre/encoder/base_encoder.py
Line 154 in 0acd945
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I was checking the
BagOne
class, and on this line:OpenNRE/opennre/model/bag_one.py
Line 46 in 0acd945
the method
sentence_encoder.tokenizer
was being used in this way:token, pos1, pos2, mask = self.sentence_encoder.tokenize(item)
However, aren't the position of
pos1
andmasks
flipped? And, what if themasks
entry is not being returned?E.g. see here:
Different order of the returned values: https://github.com/thunlp/OpenNRE/blob/master/opennre/encoder/bert_encoder.py#L215
No
masks
returned:OpenNRE/opennre/encoder/base_encoder.py
Line 154 in 0acd945
The text was updated successfully, but these errors were encountered: