Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about BagOne #353

Open
pminervini opened this issue Jan 3, 2022 · 0 comments
Open

Question about BagOne #353

pminervini opened this issue Jan 3, 2022 · 0 comments
Labels

Comments

@pminervini
Copy link

pminervini commented Jan 3, 2022

I was checking the BagOne class, and on this line:

token, pos1, pos2, mask = self.sentence_encoder.tokenize(item)

the method sentence_encoder.tokenizer was being used in this way:

token, pos1, pos2, mask = self.sentence_encoder.tokenize(item)

However, aren't the position of pos1 and masks flipped? And, what if the masks entry is not being returned?
E.g. see here:

Different order of the returned values: https://github.com/thunlp/OpenNRE/blob/master/opennre/encoder/bert_encoder.py#L215

No masks returned:

return indexed_tokens, pos1, pos2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants