Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizmo click detection is off by a constant #809

Open
MattFerraro opened this issue Dec 30, 2023 · 2 comments
Open

Gizmo click detection is off by a constant #809

MattFerraro opened this issue Dec 30, 2023 · 2 comments

Comments

@MattFerraro
Copy link
Contributor

I have a Gizmo on a page that includes an app bar and a tool bar:

Screenshot 2023-12-30 at 10 16 38 AM

When I click on the X, -X, Z, -Y, buttons, the Gizmo does not respond. It behaves as though it is not receiving mouse clicks.

BUT, when I press the Y button, the camera moves to -Y. After some experimentation I found that the gizmo is receiving click events from the following locations:

Screenshot 2023-12-30 at 10 16 38 AM

So I suspect there's a hardcoded assumption somewhere that the <Canvas> extends to the top of the viewport.

@MattFerraro
Copy link
Contributor Author

MattFerraro commented Dec 30, 2023

Digging in a bit, the assumption seems to be made on this line

I'll see if I can make a patch!

@MattFerraro
Copy link
Contributor Author

PR is here: #810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant