Fixes a bug where the local_ttl was not being calculated correctly leading to no new downloads - #11

ndejong · ndejong · commit a06cd6c9ac01 · 2025-12-08T02:16:54.000+08:00
diff --git a/src/hibp_downloader/commands/hibp_download.py b/src/hibp_downloader/commands/hibp_download.py
@@ -265,7 +265,7 @@ async def pwnedpasswords_get_and_store_async(
     if metadata_existing.data_source:
         if metadata_existing.server_timestamp:
             local_ttl = (
-                local_cache_ttl - (datetime.now().astimezone() - metadata_existing.server_timestamp).seconds  # type: ignore[operator]
+                local_cache_ttl - (datetime.now().astimezone() - metadata_existing.server_timestamp).total_seconds()  # type: ignore[operator]
             )
             if local_ttl > 0:
                 logger_.debug(f"Skipping {prefix}; local-cache has {local_ttl} time-to-live")

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ async def pwnedpasswords_get_and_store_async(`
`265`	`265`	`if metadata_existing.data_source:`
`266`	`266`	`if metadata_existing.server_timestamp:`
`267`	`267`	`local_ttl = (`
`268`		`- local_cache_ttl - (datetime.now().astimezone() - metadata_existing.server_timestamp).seconds # type: ignore[operator]`
	`268`	`+ local_cache_ttl - (datetime.now().astimezone() - metadata_existing.server_timestamp).total_seconds() # type: ignore[operator]`
`269`	`269`	`)`
`270`	`270`	`if local_ttl > 0:`
`271`	`271`	`logger_.debug(f"Skipping {prefix}; local-cache has {local_ttl} time-to-live")`