Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use existing path matching logic when filtering allowed patterns on file configs #418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

second-frank
Copy link

Resolves #414

This PR adds the possibility to use allowed_patterns together with file path wildcards in the fileignoreconfig, while still allowing file specific checksum-based ignore configs - as printed by the githook reports.

For example, something like this would be possible:

fileignoreconfig:
- filename: 'sub-folder/*.yml'
  allowed_patterns: [key]
- filename: sub-folder/foo.yml
  checksum: a21f3d967b236bd1ae3d056323c7ee054ac63b2b374dd1864d8bba21169b2b33 

The program was tested solely for our own use cases, which might differ from yours.
Frank Seidel [email protected], Mercedes-Benz Tech Innovation GmbH
Provider Information

…ile configs (thoughtworks#414)

 - requires to change ChecksumCompare too, so it considers all ignore configs (and not only the first matching one)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using "allowed_patterns" does not work with file paths that contain wildcards
1 participant