-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "allowed_patterns" does not work with file paths that contain wildcards #414
Comments
second-frank
added a commit
to mercedes-benz/talisman
that referenced
this issue
Feb 27, 2023
…ile configs (thoughtworks#414) - requires to change ChecksumCompare too, so it considers all ignore configs (and not only the first matching one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Using
allowed_patterns
in thefileignoreconfig
section does not work with file names/paths that contain wildcards.To Reproduce
With
.talismanrc
config:Steps to reproduce the behavior:
mkdir -p sub-folder
echo '@keyframes{opacity:0;transform:scale(1)}' > sub-folder/test.css
echo '{"dataKey":"foobar"}' > sub-folder/test.json
talisman --pattern '**/*'
Only the css file is ignored, while the json file is still reported.
Expected behavior
The
filename
pattern forallowed_pattern
definitions should be interpreted in the same way as forignore_detectors
.Desktop (please complete the following information):
Frank Seidel [email protected], Mercedes-Benz Tech Innovation GmbH
Provider Information
The text was updated successfully, but these errors were encountered: