-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closeSocketFor does not destroy the web socket and causes memory leak #171
Comments
@sethphillips how are you destroying the |
the proxyObject is returned from the socketFor method on the service.
|
@sethphillips thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
we tracked down a memory leak in our application that led us to sockets hanging around. turns out that the
delete get(this, 'sockets')[cleanedUrl];
removes the reference but does not destroy the proxyObject. Getting that socket proxyObject and callingdestroy()
on it does remove it from memory though.Happy to submit a PR if you need.
The text was updated successfully, but these errors were encountered: