Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make settings customizable #8

Open
jakubste opened this issue Sep 27, 2021 · 3 comments
Open

Make settings customizable #8

jakubste opened this issue Sep 27, 2021 · 3 comments

Comments

@jakubste
Copy link

Hey,

I have my poetry project in a subdirectory in the git repository. Running poetry run githooks setup fails with This is not a Git repository. Run 'git init' first. It would be nice to have the ability to overwrite GIT_DIR in settings in such cases.
@thomasthiebaud
Copy link
Owner

Hej, good idea. Would you be interested in doing a PR?

@jakubste
Copy link
Author

If you have some general guidelines on how to implement this then yeah, sure. Simply reading from environment variables with a fallback to current implementation sounds ok?

@thomasthiebaud
Copy link
Owner

yes, that sounds perfect

@AaRaBiNoZa AaRaBiNoZa mentioned this issue Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasthiebaud @jakubste