-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concurrency launch: CONCURRENCY_BROWSER definition slightly misleading #520
Comments
goelayu
changed the title
Concurrency launch: Concurrency browser definition slightly misleading
Concurrency launch: CONCURRENCY_BROWSER definition slightly misleading
Apr 4, 2023
It says CONCURRENCY_BROWSER launches one browser per url, and CONCURRENCY_CONTEXT launches an incognito page per url. So if what you're saying is true, and it only spawns one browser per worker, I would agree the docs should be updated :) |
Yes, CONCURRENCY_BROWSER launches one browser per worker, and not per URL. @thomasdondorf feel free to update the READme if you agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure if others would agree, but I felt the definition of
CONCURRENCY_BROWSER
that every URL is launched in a new browser using the incognito context, seemed misleading to me.Technically, it spawn one browser per worker, and creates a new incognito context (and a new page) per URL.
Spawning an entirely new browser per URL, would significantly inflate the loading cost (in terms of CPU usage) of each URL (as per some of my experiments).
The text was updated successfully, but these errors were encountered: