-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with dynare 4.6.1 #18
Comments
I hadn't actually tested it with Dynare 4.6 yet, as I've been distracted with other projects. Thanks for letting me know there's an issue. If the only issue is that it can't find the files it needs, you may be able to work round this by adding the +modfilename folder to your Matlab path. Is there any reason Dynare 4.5.x isn't sufficient for you though? |
Hi Tom
I've not tested dynareobc yet but noticed a couple of key changes. First is
that dynare no longer uses globals, so everything needs to be passed
through into functions as arguments instead. As a result some dynare
functions need more arguments to work. Second, some of the macroprocessor
variables are treated differently. Not sure this will affect dynareOBC but
it would do our spatial code, although we can just use an older version of
dynare.
Best
Jonathan
…On Sat, Apr 25, 2020, 11:50 Tom Holden, ***@***.***> wrote:
I hadn't actually tested it with Dynare 4.6 yet, as I've been distracted
with other projects. Thanks for letting me know there's an issue. If the
only issue is that it can't find the files it needs, you may be able to
work round this by adding the +modfilename folder to your Matlab path.
Is there any reason Dynare 4.5.x isn't sufficient for you though?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACASQSDZBMWIF7RBPPTWWG3ROMBFZANCNFSM4MQUNB7Q>
.
|
Exactly as Jonathan said, I don't really need the new version, I can still use the previous one. It just happened to me to try dynare on a new machine and realize that the toolkit is not compatible with this new version. |
OK. It's on the TODO list, and I'll try to do it sooner rather than later. But it may still be a month or so. |
As of commit b352697 there is basic support for Dynare 4.6. Results may still be unexpected though, so I still recommend at least running a sanity check with Dynare 4.5 for the time being. There is no support for MLV simulation under Dynare 4.6 however, due to the removal of essential information by the Dynare time. Hopefully, this will be addressed in a future Dynare version, see: https://git.dynare.org/Dynare/dynare/-/issues/1722 This commit will be included in a new DynareOBC release very shortly. |
Dear tholden, Thank you for your incredible work providing this important tool for dynare.
I have just a small question:
do you plan to update the code soon to made it compatible with the new dynare 4.6?
I believe that the main reason it doesn't work with this version is the new folder +modfilename which include all the functions created by dynare but I'm not sure it's only this and I wouldn't want to mess up the code by modifying it myself.
Thanks again.
The text was updated successfully, but these errors were encountered: