Skip to content

Compatibility with react 19 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dartess opened this issue Jan 16, 2025 · 7 comments
Open

Compatibility with react 19 #92

dartess opened this issue Jan 16, 2025 · 7 comments

Comments

@dartess
Copy link

dartess commented Jan 16, 2025

npm i react-simple-pull-to-refresh
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"^19.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"^16.10.2 || ^17.0.0 || ^18.0.0" from [email protected]
@dartess
Copy link
Author

dartess commented Jan 16, 2025

@thmsgbrt hey! Thank you for this project! Can you tell a little about its status?

Will you have time and desire to check compatibility with react 19 and update the package?

If not, will you have time and desire to look at the PR from the community?

If not, please write about it, so that your project does not become a blocker for the update.

Thanks in advance for your answer!

@esskar
Copy link

esskar commented Feb 26, 2025

@dartess Have you found a solution or an alternative?

@dartess
Copy link
Author

dartess commented Feb 27, 2025

@esskar

I tried several react libraries and none of them showed themselves as "just works" (like react-simple-pull-to-refresh).

So... @operato/pull-to-refresh + useEffect looks OK, I settled on it. But I'm not sure if you can customize the appearance there.

@esskar
Copy link

esskar commented Feb 27, 2025

So... @operato/pull-to-refresh + useEffect looks OK, I settled on it. But I'm not sure if you can customize the appearance there.

Thanks. it's github page points to nowhere though.

@dartess
Copy link
Author

dartess commented Feb 27, 2025

Yeah (( doesn't look good and safe.
Just in case I analyzed the sources after installing the package and locked the version.

@esskar
Copy link

esskar commented Feb 27, 2025

I justed ended up including the source from here directly in my app

@redimongo
Copy link

Might because of this issue when adding react 19 and react-dom 19 I got these following warnings.

I have folk the project and will look at the code and see if I can fix/resolve some of these issues.

npm install
npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: this library is no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.
npm warn deprecated
npm warn deprecated (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: This SVGO version is no longer supported. Upgrade to v2.x.x.
npm warn deprecated [email protected]: Node Sass is no longer supported. Please use `sass` or `sass-embedded` instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants