Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing python module should not trigger package installation #39

Open
pbrkr opened this issue Mar 14, 2023 · 0 comments · May be fixed by #51
Open

Importing python module should not trigger package installation #39

pbrkr opened this issue Mar 14, 2023 · 0 comments · May be fixed by #51

Comments

@pbrkr
Copy link

pbrkr commented Mar 14, 2023

After the last commit (7b1ffcc), import of sdk_utils or anything which depends on it (tb_device_mqtt & tb_gateway_mqtt) will result in attempted installation of mmh3/pymmh3 via pip. This is counter-intuitive and surprising - importing a Python module should not have side effect which modify the system state.

Furthermore, this makes the tb-mqtt-client package unusable on embedded systems which either lack pip (to save space), have a read-only rootfs or lack internet access. Automated installation of packages at runtime also breaks installation reproducibility (as there's no way to control which version of the dependency is installed) and defeats attempts to achieve license compliance.

Dependencies should be expessed in setup.py so that they can be installed in the usual way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant