-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which tests should be required before merge? #320
Labels
Comments
In my opinion we should have DCO and unit tests passing required as a bare minimum. Pushing and merging broken code (e.g. something that doesn't pass tests) should not be allowed to be merged. Linting is debatable and so is CodeQL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have various checks we run on PR's:
We just made DCO passing required for merges to main, should any other checks be required?
The text was updated successfully, but these errors were encountered: