Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonic Colors Ultimate ExecutableName #874

Closed
wants to merge 0 commits into from

Conversation

TBirdSoars
Copy link

fixes #873

@ActualMandM
Copy link
Collaborator

Wouldn't this cause the issue to happen for EGS users instead?

@TBirdSoars
Copy link
Author

I was not aware the executable was actually named differently between the stores. I only have it on Steam, so I can't test if this would impact EGS users. That would definitely make this more complicated.

@DeaTh-G
Copy link
Collaborator

DeaTh-G commented Apr 11, 2024

The executable name on the EGS version is indeed name differently and is using the name that is already present in HMM.

@thesupersonic16
Copy link
Owner

thesupersonic16 commented Apr 14, 2024

Looks like an oversight while trying to get the Steam version added. The solution will need to include checking the path instead of the exe name.

I believe we would only need to update FindAndSetLocalGame in HedgeApp.xaml.cs.

EDIT:
Maybe you can just get the filename from GamePath/GamePathEGS. The game install searching works by sending back the directory that contains the exe.
Maybe even GameInstall.SearchForGames aswell for ExtraGameDirectories.

@TBirdSoars
Copy link
Author

Looks like an oversight while trying to get the Steam version added. The solution will need to include checking the path instead of the exe name.

I believe we would only need to update FindAndSetLocalGame in HedgeApp.xaml.cs.

EDIT: Maybe you can just get the filename from GamePath/GamePathEGS. The game install searching works by sending back the directory that contains the exe. Maybe even GameInstall.SearchForGames aswell for ExtraGameDirectories.

I've tried to implement that GamePath fix in dae9236, replacing every seemingly relevant ExecutableName with a check for GamePath/GamePathEGS. While this did fix my issue with the Steam version, I'm still encountering a similar issue with the EGS version now that I have it to test.

I've also tried a different approach by adding the EGS version as its own Game with 2025ee8. This appeared to fix my issue and avoids having so many extra checks for the GamePath/GamePathEGS, but resulted in the combo box having two entries named "Sonic Colors: Ultimate", without the launcher names included. Modifying the duplicate checking to use GameName instead of BaseGame seems to have corrected this.

I'm not sure which approach is necessarily better.

@thesupersonic16
Copy link
Owner

I currently have an uncommitted change that might help with this issue. May ask in here once I push it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonic Colors Not Being Saved as Last Game
4 participants