Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Annotation Toggle Panel #36

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Annotation Toggle Panel #36

wants to merge 7 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Nov 24, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This pull request adds a new component called AnnotationTogglePanel to the project. This component allows users to toggle the display of different annotations on the genome display.

Summary

  • Added AnnotationTogglePanel component
  • Imported AnnotationTogglePanel in App.js
  • Added AnnotationTogglePanel to the SearchPanel component
  • Added state and logic to handle annotation toggles in AnnotationTogglePanel component
  • Updated GensploreView component to pass annotation toggles to GenomeDisplay component
  • Created GenomeDisplay component to display annotations based on toggles
  • Updated App.js to include AnnotationTogglePanel in the render

Fixes #35.

🎉 Latest improvements to Sweep:

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai Sweep AI
Copy link
Contributor Author

sweep-ai bot commented Nov 24, 2023

Sandbox Executions

  • Ran sandbox for src/components/AnnotationTogglePanel.js. ✓
Sandbox logs for https://github.com/theosanderson/gensplore/commit/9b0a7c89ed58c9211e460184de093f820b095536
trunk fmt src/components/AnnotationTogglePanel.js || exit 0 1/2 ✓ 
 ✔ Formatted src/components/AnnotationTogglePanel.js
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --print-failures src/components/AnnotationTogglePanel.js 2/2 ✓ 
Checked 1 file
✔ No issues
  • Ran sandbox for src/App.js. ✗
Sandbox logs for
trunk fmt src/App.js || exit 0 1/2 ✓ 
  FAILURES  
 prettier  src/App.js  .trunk/out/oJO6G.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 0 files
✖ No issues, 1 failure
trunk check --fix --print-failures src/App.js 2/2 ❌ (`1`) 
  FAILURES  
 prettier  src/App.js  .trunk/out/MlCBs.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 1 file
✖ No issues, 1 failure
# .trunk/out/MlCBs.yaml
trunk_cli_version: 1.17.2
title: prettier exited with exit_code=2
report:
  - prettier exited with exit_code=2
  - linter:
      command: |
        /root/.cache/trunk/tools/prettier/3.1.0-a552fdee5ef3daae1274e7dca8183c14/node_modules/.bin/prettier -w src/App.js
      stdin_path: (none)
      run_from: /tmp/trunk-0/sFQXXY/SR2Ryp
      timeout: 10m
      rerun: (cd /tmp/trunk-0/sFQXXY/SR2Ryp; env -i PATH=/root/.cache/trunk/tools/prettier/3.1.0-a552fdee5ef3daae1274e7dca8183c14/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin NODE_PATH=/root/.cache/trunk/tools/prettier/3.1.0-a552fdee5ef3daae1274e7dca8183c14/node_modules HOME=/root /root/.cache/trunk/tools/prettier/3.1.0-a552fdee5ef3daae1274e7dca8183c14/node_modules/.bin/prettier -w src/App.js)
      affects_cache:
        - package.json
      direct_configs:
        []
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        [error] src/App.js: SyntaxError: Unexpected token (472:11)
        [error]   470 |        472 |           
        [error]       |           ^
        [error]   473 |       >
        [error]   474 |         Customize appearance
        [error]   475 |       
    parser: |
      (none)
  • Ran sandbox for src/App.js. ✓
Sandbox logs for https://github.com/theosanderson/gensplore/commit/44ecd3f565d6d219efbf343f6f1dd76532886fc2
trunk fmt src/App.js || exit 0 1/2 ✓ 
 ✔ Formatted src/App.js
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --print-failures src/App.js 2/2 ✓ 
Checked 1 file
✔ No issues
  • Ran sandbox for src/App.js. ✓
Sandbox logs for
trunk fmt src/App.js || exit 0 1/2 ✓ 
Checked 1 file
✔ No issues
trunk check --fix --print-failures src/App.js 2/2 ✓ 
Checked 1 file
✔ No issues
  • Ran sandbox for src/components/GenomeDisplay.js. ✓
Sandbox logs for https://github.com/theosanderson/gensplore/commit/60e8d7afa39791c2b0537b6b5b738adf4cff895d
trunk fmt src/components/GenomeDisplay.js || exit 0 1/2 ✓ 
 ✔ Formatted src/components/GenomeDisplay.js
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --print-failures src/components/GenomeDisplay.js 2/2 ✓ 
Checked 1 file
✔ No issues

@sweep-ai Sweep AI
Copy link
Contributor Author

sweep-ai bot commented Nov 24, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Nov 24, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
genbank-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 1:21pm

@sweep-ai sweep-ai bot mentioned this pull request Nov 24, 2023
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sweep: add a panel to toggle individual annotations
0 participants