Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure: strict order of json manifests #78

Closed
quadrophobiac opened this issue Sep 17, 2015 · 1 comment
Closed

structure: strict order of json manifests #78

quadrophobiac opened this issue Sep 17, 2015 · 1 comment

Comments

@quadrophobiac
Copy link
Collaborator

The current order of the respective package.json files has created duplication of bower_components and node_modules.

To resolve this for future versions I suggest creating an additional root package.json that handles node dependencies and deprecating node dependencies listed in app/package.json (node require within app/ will resolve to searching parent directory) and leaving app/package.json responsible for stipulating the electron main process.

Bower.json can remain within app/ for now as the complete modularisation of javascript requirements is still pending (there are lots of script tags that need refactoring)

app/package.json

{
  "name": "comma-chameleon",
  "version": "0.1.0",
  "main": "main.js"
}

/package.json

{
  "name": "comma-chameleon",
  "version": "0.1.0",
  "license": "MIT",
  "main": "main.js",
  "scripts": {
    "start": "electron app"
  },
  "repository": {
    "type": "git",
    "url": "https://github.com/theodi/comma-chameleon.git"
  },
  "dependencies": {
    "request": "^2.60.0",
    "xlsx": "^0.8.0",
    "node-zip": "^1.1.1"
  },
  "devDependencies": {
    "chai": "^3.2.0",
    "electron-mocha": "^0.3.1",
    "electron-prebuilt": "^0.33.0"
  }
}
@quadrophobiac
Copy link
Collaborator Author

suggestions made here are all covered by any future move to yarn (see #158) so I am closing this ticket for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant