Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS vulnerabilities #8

Open
yunai39 opened this issue Oct 7, 2021 · 0 comments
Open

XSS vulnerabilities #8

yunai39 opened this issue Oct 7, 2021 · 0 comments

Comments

@yunai39
Copy link

yunai39 commented Oct 7, 2021

Hello,

In commit ad946eb34293c72d0743f6c4febd2155a957b64e

I was changed from this

$queryString = $this->request->getQueryString();

To this

if (null === $queryString = $this->request->server->get('QUERY_STRING')){
    $queryString = $this->request->getQueryString();
}

$this->request->server->get('QUERY_STRING')), return an str which is not normalized and this create an XSS vulnerability.

If you call https://demo.thelia.net/?"><script>alert(81)</script>= (in a browser that does not encode url or using postman), you can will get <script>alert(81)</script> render in the dom and interpreted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant