Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build warnings in Node 14 #1152

Open
jason0x43 opened this issue May 14, 2020 · 3 comments
Open

Build warnings in Node 14 #1152

jason0x43 opened this issue May 14, 2020 · 3 comments
Labels
effort-low Should be pretty quick priority-low We'll get to this eventually project-dev Updates to Intern's organization or dev process
Projects
Development

Comments

@jason0x43
Copy link
Member

When building Intern 4.x or 5 under Node 14, many circular dependency warnings will be displayed:

(node:87088) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:87088) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:87088) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:87088) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:87088) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency

These don't affect the build process, they're just annoying. They also don't affect Intern when used as a library, only the Intern build process.

The culprits appear to be shelljs and stylus. Shelljs fixes the issue in v0.8.4. Stylus doesn't yet have a fix.
@jason0x43 jason0x43 added effort-low Should be pretty quick project-dev Updates to Intern's organization or dev process priority-low We'll get to this eventually labels May 14, 2020
@github-actions github-actions bot added this to To do in Development May 14, 2020
@jason0x43
Copy link
Member Author

See stylus/stylus#2534, shelljs/shelljs#991

@jason0x43 jason0x43 self-assigned this May 17, 2020
@github-actions github-actions bot moved this from To do to In progress in Development May 17, 2020
@jason0x43
Copy link
Member Author

Partially addressed in 64e305d

@jason0x43 jason0x43 removed their assignment May 17, 2020
@github-actions github-actions bot moved this from In progress to To do in Development May 17, 2020
@sunderla
Copy link

This issue has been resolved for stylus 0.54.8 and does not display these errors anymore. See #2538. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-low Should be pretty quick priority-low We'll get to this eventually project-dev Updates to Intern's organization or dev process
Projects
Development
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jason0x43 @sunderla