Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C leaves process running #80

Open
rhpijnacker opened this issue Apr 20, 2020 · 7 comments · May be fixed by #81
Open

Ctrl-C leaves process running #80

rhpijnacker opened this issue Apr 20, 2020 · 7 comments · May be fixed by #81
Labels

Comments

@rhpijnacker
Copy link

When I start Intern with e.g. the BrowserStack tunnel and I use ctrl-c to stop Intern, then the tunnel processes are cleaned up properly, but the node process itself stays running.

@rhpijnacker rhpijnacker linked a pull request Apr 20, 2020 that will close this issue
@jason0x43
Copy link
Member

What OS does this happen on and with which version of Node?

@rhpijnacker
Copy link
Author

I happens on Windows 10 with Node v10.15.1 and MacOS with Node v12

@jason0x43
Copy link
Member

Which node process is left running? I mean, dies the CLI interface die, dropping you back at a prompt, or does Intern just keep running?

@rhpijnacker
Copy link
Author

rhpijnacker commented Apr 21, 2020

When I start npm run intern config=... and then Ctrl-C, I get back to the command prompt, then the tunnel child processes are still running when using a Selenium tunnel. For BrowserStack it does cleanup the child processed. In any case the node process is still running (and keeping the port locked, which is why I noticed).
Could it be that it does not shut down the webserver properly?

All this on Windows 10, node v10.15.1

@jason0x43
Copy link
Member

jason0x43 commented Apr 21, 2020

Which port is locked? 9000 (or whatever is being used for Intern's server)?

@jason0x43 jason0x43 added the bug label Jun 5, 2020
@jason0x43
Copy link
Member

I've seen this when running dev Intern via npx, but only when a tunnel is active.

@jason0x43
Copy link
Member

(And I forgot to mark this as a bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants