Unable to set Apache Ports if it includes an IP

[vollmerk]

Currently the ssl_server_port ans server_port only allows integers

  Integer[0, 65535] $server_port = $::foreman::server_port,
  Integer[0, 65535] $server_ssl_port = $::foreman::server_ssl_port,

However Apache allows you to bind to a specific IP+Port, example

Listen 10.50.10.10:80
Listen 10.50.10.11.443

Validation on port/Listen result needs to be significantly more complex :( allowing for IPv4 + Port or IPv6 + Port. I was going to just submit a pull-request but it got messy, so my question is now should there be a crazy IP regular expression which includes the colon and the port range, oooor just string or?

[mmoll]

Whatever puppetlabs-apache is providing could be re-used, but prestarting the Rails app also needs to continue to work.

[vollmerk]

Easy - but not slick

• Distinct Variables for Apache Listen lines?

Harder, but 'slicker'

• Regex-split server port into two variables IP & Port allowing the pre-start code to still work

[ekohl]

I'm not sure what you're trying to do is supposed to work. If I read the code of apache::vhost correct then it should generate the correct apache::listen based on the IP + port so injecting an IP + port combo into $port will break certain use cases. If you want to bind a specific IP then we have the $listen_on_interface parameter but I will agree that it's a bad parameter and we should support the direct IP as well. I'd prefer exposing an explicit IP parameter over splitting a port.

[vollmerk]

@adamundefined - Can you take a crack at this, when you get a chance?

[mmoll]

what's the status here?

[Zugschlus]

I need that functionality as well, preferrably as a list of IP addresses so that 127.0.0.1 can be explicitly included. I am not the original poster, but what exactly what is this issue waiting from the contributor?

Greetings
Marc

[vollmerk]

Yeah, also who is the contributor? do you mean reporter (aka me?)

[mmoll]

@vollmerk after your second comment I had the impression you'd work on it, but I'll remove the label then.

Pull requests welcome. :)