Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Tech review not needed" label #3366

Open
apinnick opened this issue Oct 10, 2024 · 2 comments
Open

Add "Tech review not needed" label #3366

apinnick opened this issue Oct 10, 2024 · 2 comments

Comments

@apinnick
Copy link
Contributor

I think it would be useful to create a "Tech review not needed" label for PRs that fix only style issues.

@maximiliankolb
Copy link
Contributor

I did some cleanup and deleted unused labels. current list: https://github.com/theforeman/foreman-documentation/issues/labels

alternative to "tech review not needed": use "tech review done".

@apinnick
Copy link
Contributor Author

The problem with that is that people assume "tech review done" means tech review was done. A PR was marked 'tech review done' when it did not need tech review. However, it turned out that the PR should have gone through tech review.

Labels that are not precise cause confusion. That is why I am proposing this label. For that matter, I think "Style review not needed" would also be a good idea.

@asteflova asteflova mentioned this issue Nov 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants