Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mac OS ventura and sonoma #32

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

tavvfiq
Copy link

@tavvfiq tavvfiq commented Jan 18, 2023

this PR add support for mac OS ventura since the system settings is using different layout.
the implementation is using osascript with javascript. feel free if you have any input. thanks

@tavvfiq tavvfiq changed the title Add support for mac OS ventura Added support for mac OS ventura Jan 18, 2023
@tavvfiq tavvfiq changed the title Added support for mac OS ventura Support for mac OS ventura Jan 18, 2023
Noddy20 added a commit to Noddy20/lazy-connect that referenced this pull request Apr 10, 2023
@esafirm
Copy link

esafirm commented Aug 15, 2023

For me, there's a password popup after focusing on passwordField that causing the ok.click() or cancel.click() failed.

The solution is to focus on another field, in my case the user field

const passwordField = authArea.textFields[1]
passwordField.focused = true
passwordField.value = password
        
+ const userField = authArea.textFields[0]
+ userField.focused = true

@tavvfiq
Copy link
Author

tavvfiq commented Aug 31, 2023

cool @esafirm. will add this changes. thanks

@bilfash
Copy link

bilfash commented Nov 19, 2023

Hai @tavvfiq, Mind to update the script with the latest mac os sonoma? :)

@tavvfiq
Copy link
Author

tavvfiq commented Nov 27, 2023

@bilfash i havent update my os to sonoma yet😅. But will update the PR once its done

@tavvfiq
Copy link
Author

tavvfiq commented Dec 1, 2023

hi @bilfash, just updated the PR with support for sonoma. please kindly help on testing ya. thanks!

P.S: please delete existing VPN first, and then re-adding the VPN again (since this impl. is using different approach)

@tavvfiq tavvfiq changed the title Support for mac OS ventura Support for mac OS ventura and sonoma Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants