String and str both used in docs #683
-
|
When specifying the expected type of data in the documentation, both string and str are used. We should probably unify them unless there is an intentional difference (if so, it should also be documented). Example:
|
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
This should all be (str), especially after I recently refactored the type conversion code to fix some minor issues. (string) might be used to denote the Pandas StringDtype, but we don't want to use that right now. It obviously has its advantages but it not being a builtin python dtype might break code for some people. |
Beta Was this translation helpful? Give feedback.
-
|
Ok I will submit a PR |
Beta Was this translation helpful? Give feedback.
This should all be (str), especially after I recently refactored the type conversion code to fix some minor issues. (string) might be used to denote the Pandas StringDtype, but we don't want to use that right now. It obviously has its advantages but it not being a builtin python dtype might break code for some people.
This looks a lot like I was just careless when writing documentation.