Skip to content
This repository has been archived by the owner on Jan 18, 2023. It is now read-only.

API - team json - "zip code" is string not always a number #387

Open
lancelarsen opened this issue Oct 16, 2020 · 1 comment
Open

API - team json - "zip code" is string not always a number #387

lancelarsen opened this issue Oct 16, 2020 · 1 comment
Labels

Comments

@lancelarsen
Copy link

"zip code" is string not number
In the api models, "zip code" is listed as being a "number" - but at least one value coming back in json is non-numeric as our json deserializer complained about zip - so there must be a non-numeric in the data set. Believe that the model docs just need to be updated.

{"team_key":"18599","region_key":"MO","league_key":null,"team_number":18599,"team_name_short":"OFHS Team 5","team_name_long":"Orchard Farm High School","robot_name":null,"last_active":"2021","city":"Saint Charles","state_prov":"MO","zip_code":"63301","country":"USA","rookie_year":2020,"website":null}

Looks like the only values not coming back in quotes that we see in the json are "team_number" and "rookie_year"

@Techno11
Copy link
Collaborator

This may have something to do with not all "postal codes" from FIRST for all countries are numbers. I'll have to check the data and how we store it in the DB, but this is definitely not right.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants