Skip to content

Conversation

@PaiJi
Copy link
Contributor

@PaiJi PaiJi commented Nov 29, 2025

improve search button style in disabled and loading state

Currently, the search button provides no noticeable visual feedback when it is disabled or performing a search (even if there is any, it is too subtle to perceive). This PR aims to add styling so that the search button gives users clear visual cues when it is disabled or searching.

Description 🗒️

Examples 📸

Disabled

image

Enabled

image

Searching

image

Related Issues 🔗


Expand for Help

By submitting this pull request, you agree to our code of conduct

@PaiJi PaiJi requested a review from a team as a code owner November 29, 2025 18:17
Copy link
Member

@Razzmatazzz Razzmatazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like a good improvement!

@PaiJi
Copy link
Contributor Author

PaiJi commented Nov 30, 2025

Thanks for the PR! Looks like a good improvement!

Look like the CI still waiting for approve?🤔

@Razzmatazzz
Copy link
Member

Yeah, had to get approval for another PR and get that merged before getting this one taken care of.

@Razzmatazzz
Copy link
Member

.deploy

@github-actions
Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production (branch: 6436ed806c6c36346899ca7384aef09447574ce0)

You can watch the progress here 🔗

Details
{
  "type": "branch",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "timestamp": "2025-11-30T20:20:32.063Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/19804330418"
  },
  "git": {
    "branch": "6436ed806c6c36346899ca7384aef09447574ce0",
    "commit": "6436ed806c6c36346899ca7384aef09447574ce0",
    "verified": true,
    "committer": "web-flow",
    "html_url": "https://github.com/the-hideout/tarkov-dev/commit/6436ed806c6c36346899ca7384aef09447574ce0"
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": true,
    "comment": {
      "created_at": "2025-11-30T20:20:18Z",
      "updated_at": "2025-11-30T20:20:18Z",
      "body": ".deploy",
      "html_url": "https://github.com/the-hideout/tarkov-dev/pull/1179#issuecomment-3593286642"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

@github-actions
Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch 6436ed806c6c36346899ca7384aef09447574ce0 to production

Details
{
  "status": "success",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "id": 3395111647,
    "timestamp": "2025-11-30T20:23:06.582Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/19804330418",
    "duration": 155
  },
  "git": {
    "branch": "6436ed806c6c36346899ca7384aef09447574ce0",
    "commit": "6436ed806c6c36346899ca7384aef09447574ce0",
    "verified": true
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": true
  },
  "reviews": {
    "count": 2,
    "decision": "APPROVED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

Environment URL: tarkov.dev

@Razzmatazzz Razzmatazzz merged commit 499a9aa into the-hideout:main Nov 30, 2025
2 checks passed
@PaiJi PaiJi deleted the style/player-search-button branch December 1, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants