-
-
Notifications
You must be signed in to change notification settings - Fork 62
style(players): improve search button style in disabled and loading state #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(players): improve search button style in disabled and loading state #1179
Conversation
Razzmatazzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks like a good improvement!
Look like the CI still waiting for approve?🤔 |
|
Yeah, had to get approval for another PR and get that merged before getting this one taken care of. |
|
.deploy |
Deployment Triggered 🚀Razzmatazzz, started a branch deployment to production (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "production",
"url": "https://tarkov.dev"
},
"deployment": {
"timestamp": "2025-11-30T20:20:32.063Z",
"logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/19804330418"
},
"git": {
"branch": "6436ed806c6c36346899ca7384aef09447574ce0",
"commit": "6436ed806c6c36346899ca7384aef09447574ce0",
"verified": true,
"committer": "web-flow",
"html_url": "https://github.com/the-hideout/tarkov-dev/commit/6436ed806c6c36346899ca7384aef09447574ce0"
},
"context": {
"actor": "Razzmatazzz",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-11-30T20:20:18Z",
"updated_at": "2025-11-30T20:20:18Z",
"body": ".deploy",
"html_url": "https://github.com/the-hideout/tarkov-dev/pull/1179#issuecomment-3593286642"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅Razzmatazzz successfully deployed branch Details{
"status": "success",
"environment": {
"name": "production",
"url": "https://tarkov.dev"
},
"deployment": {
"id": 3395111647,
"timestamp": "2025-11-30T20:23:06.582Z",
"logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/19804330418",
"duration": 155
},
"git": {
"branch": "6436ed806c6c36346899ca7384aef09447574ce0",
"commit": "6436ed806c6c36346899ca7384aef09447574ce0",
"verified": true
},
"context": {
"actor": "Razzmatazzz",
"noop": false,
"fork": true
},
"reviews": {
"count": 2,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
}
|
improve search button style in disabled and loading state
Currently, the search button provides no noticeable visual feedback when it is disabled or performing a search (even if there is any, it is too subtle to perceive). This PR aims to add styling so that the search button gives users clear visual cues when it is disabled or searching.
Description 🗒️
Examples 📸
Disabled
Enabled
Searching
Related Issues 🔗
Expand for Help