Skip to content

Eslint fails in CI #741

@Relequestual

Description

@Relequestual

Repos which use the eslint config published by this repo run into a problem where eslint exits with code 1. For example: https://github.com/the-guild-org/website/actions/runs/15630837568/job/44034593226

Image

It looks like the issue is related to upgrade of eslint-plugin-unicorn.

This requires ESM dynamic import, which only works fully on ESLint 9, which is defined as a requirement (although this is missed at install?)

It was updated in the-guild configs here: 20476f5

Downgrading it from 57 to 56 should resolve the eslint failing.

I have also looked at updating to eslint 9. (Renovate tried to do this but was blocked)

I have done the migration work locally for the website repo, but it still uses 8 because that's what's defined as required by @theguild/eslint-config.
So, that approach is a dead end unless @theguild/eslint-config updates to 9 also.
This would require all repos that use it to then also migrate to 9 if they update their version.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions