Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Google Fonts are present #43

Open
sawyerclick opened this issue Jun 17, 2022 · 3 comments
Open

Check if Google Fonts are present #43

sawyerclick opened this issue Jun 17, 2022 · 3 comments
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@sawyerclick
Copy link
Contributor

We currently have includeGoogleFonts shipping true by default with a user input to turn it false. Is there a case where a file wouldn't have any Google Fonts, and would we have a way to check that? The ideal flow there would be that the Google Fonts toggle would be disabled and stuck on false
@sawyerclick sawyerclick added the enhancement New feature or request label Jun 17, 2022
@sawyerclick sawyerclick added this to the 1.0.0 milestone Jun 17, 2022
@sawyerclick sawyerclick changed the title Add check for if Google Fonts are in file Check if Google Fonts are present Jun 17, 2022
@svickars
Copy link
Collaborator

I have so far been unable to find a way to do this. Do think it would be a great add though

@sawyerclick
Copy link
Contributor Author

It seems like this uses an API key or something of the sort - but something like this would get us all fonts that Google has, which we could then check local fonts against:

https://www.googleapis.com/webfonts/v1/webfonts?key=AIzaSyBwIX97bVWr3-6AIUvGkcNnmFgirefZ6Sw

@svickars
Copy link
Collaborator

Great find, let me look into this!

@sawyerclick sawyerclick added bug Something isn't working and removed enhancement New feature or request labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@svickars @sawyerclick