-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedup ExpandPostings call #7170
Labels
Comments
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your proposal related to a problem?
Similar to #7169, duplicate requests of expanding postings for the same matchers, can consume a lot of bandwidth and CPU.
Describe the solution you'd like
Introduce https://pkg.go.dev/golang.org/x/sync/singleflight to https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L1099 to dedup
ExpandPostings
requests.It is not enough to just do #7169 because #7169 only dedups requests to cache. However, postings insection/merge operations are still duplicated.
The text was updated successfully, but these errors were encountered: