-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Ads not being blocked while using the " In-Player " adblocker #1817
Comments
Also have this issue. Swapping between in-player and blocklist does nothing and ads still appear. OS: Windows 10 Home YT Music Version: 3.3.4 Plugins Enabled: |
did this issue fixed? using 3.3.5 still appeared. |
YT has changed the logic around showing ads, please use |
I'm going to copy my solution here:
Adherence to protocol is fine, but don't use it to needlessly burying the issue and solutions to it |
#1955 (comment) is also a viable fix. Using a link instead of a path removes the need to download the list |
If I'm not mistaken, it looks like Ublock Origin uses this service (adtidy.org). We should add it to the default block list here. |
It's an optimized list maintained by AdGuard. It's generally lighter on resources and more up to date than the list featured in the adblockers themselves - since the one I'm using (Fanboy Annoyances) /is/ on that lists, just out of date. Why I prefer them over uBlock Origin's in general |
+1, blocklist is working fine. |
Added another blocklist source provided by Trixarian in th-ch#1817. This will block ads that many users have been experiencing in the application.
Update
|
where to put this line in the json? i'm trying everything. Ads still there |
i think i found how to activate this, had to switch to "block list" in the app: |
This is not anything bad, but correct me if i'm wrong, back in 2023 didn't we decide to switch to "In Player" because of the RAM usage leak that was happening from the "Blocklists" option? Did we ever fix that? I got busy with university so I had to temporarily drop this project |
@DereC4 Yes, that issue has been resolved. |
If this is the definitive fix to the issue of ads not being blocked then shouldn't this be pushed in the next update? |
Note that this solution breaks search feature. |
This is happening on Mac as well: Macbook air m2 Enabled plugins:
Version: 3.3.6 |
neat |
Fixed at 1f1efac |
Preflight Checklist
YouTube Music (Application) Version
3.3.2
Checklists
What operating system are you using?
Windows
Operating System Version
Windows 11 23H2 22631.3155
What CPU architecture are you using?
x64
Last Known Working YouTube Music (Application) version
No response
Reproduction steps
Expected Behavior
Music to play without any ads
Actual Behavior
2 30 seconds ads playing
Enabled plugins
Additional Information
If using the In player ad blocker , ads aren't being blocked . Using the " blocklists " function mitigates this issue . Hereby attaching a screenshot of the ad playing . Please feel free to reach out to me if you need any more information,
The text was updated successfully, but these errors were encountered: