Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ads not being blocked while using the " In-Player " adblocker #1817

Closed
3 of 5 tasks
XCalibur5678 opened this issue Mar 2, 2024 · 19 comments
Closed
3 of 5 tasks
Labels
bug Something isn't working fix-available A fix to the issue is available in a new version

Comments

@XCalibur5678
Copy link

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.3.2

Checklists

  • I use the portable version of the YouTube Music Application.
  • I can reproduce this issue in the official YTM web version.

What operating system are you using?

Windows

Operating System Version

Windows 11 23H2 22631.3155

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Switch to Plugins>Adblocker>Blocker>In Player
  2. Play any song

Expected Behavior

Music to play without any ads

Actual Behavior

2 30 seconds ads playing

Enabled plugins

  1. Adblocker
  2. Album Actions
  3. Blur Navigation Bar
  4. Downloader
  5. In app Menu
  6. Lyrics Genius
  7. Navigation
  8. SponsorBlock
  9. Taskbar media control
  10. Video Toggle

Additional Information

If using the In player ad blocker , ads aren't being blocked . Using the " blocklists " function mitigates this issue . Hereby attaching a screenshot of the ad playing . Please feel free to reach out to me if you need any more information,

image

@JellyBrick JellyBrick added bug Something isn't working help wanted Extra attention is needed labels Mar 3, 2024
@Joey451-OG
Copy link
Contributor

I can confirm this is happening on Linux as well:

Linux Version:
Ditro: Fedora 39
Architeture: x86_64

Version: 3.3.2

Enabled Plugins:

  1. Adblocker (In-Player)
  2. Discord Rich Presence
  3. Navigation

Please let me know if I can be of further assistance. I love using this tool :D

image

@BrandTruong
Copy link

Also have this issue. Swapping between in-player and blocklist does nothing and ads still appear.

OS: Windows 10 Home
OS Version: 10.0.19045 Build 19045
System Type: x64-based PC

YT Music Version: 3.3.4

Plugins Enabled:
Ad Blocker
Album Color Theme
Discord Rich Presence
Downloader
In-App Menu
Navigation
Sponsorblock

@frrrrrits
Copy link

did this issue fixed? using 3.3.5 still appeared.

@JellyBrick
Copy link
Collaborator

JellyBrick commented Mar 27, 2024

did this issue fixed? using 3.3.5 still appeared.

YT has changed the logic around showing ads, please use blocklists mode until we can figure out the issue.

@Trixarian
Copy link

I'm going to copy my solution here:

Toggle with blocklists under Blocker in the ad blocker Plugin. Go to Options---> Advanced options---> Edit config.json and change:

			"additionalBlockLists": [],

to

			"additionalBlockLists": [
				"https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt"
			],

and restart the app
That solves the ads issue for me

Adherence to protocol is fine, but don't use it to needlessly burying the issue and solutions to it

@Trixarian
Copy link

#1955 (comment) is also a viable fix. Using a link instead of a path removes the need to download the list

@Joey451-OG
Copy link
Contributor

If I'm not mistaken, it looks like Ublock Origin uses this service (adtidy.org).

We should add it to the default block list here.

@Trixarian
Copy link

If I'm not mistaken, it looks like Ublock Origin uses this service (adtidy.org).

We should add it to the default block list here.

It's an optimized list maintained by AdGuard. It's generally lighter on resources and more up to date than the list featured in the adblockers themselves - since the one I'm using (Fanboy Annoyances) /is/ on that lists, just out of date. Why I prefer them over uBlock Origin's in general

@lucastwg
Copy link

+1, blocklist is working fine.

Joey451-OG added a commit to Joey451-OG/youtube-music that referenced this issue Apr 11, 2024
Added another blocklist source provided by Trixarian in th-ch#1817. This will block ads that many users have been experiencing in the application.
@JellyBrick
Copy link
Collaborator

JellyBrick commented Apr 13, 2024

Update

@JellyBrick JellyBrick pinned this issue Apr 13, 2024
@peppepascale
Copy link

I'm going to copy my solution here:

Toggle with blocklists under Blocker in the ad blocker Plugin. Go to Options---> Advanced options---> Edit config.json and change:

			"additionalBlockLists": [],

to

			"additionalBlockLists": [
				"https://filters.adtidy.org/extension/ublock/filters/122_optimized.txt"
			],

and restart the app
That solves the ads issue for me

Adherence to protocol is fine, but don't use it to needlessly burying the issue and solutions to it

where to put this line in the json? i'm trying everything. Ads still there

@peppepascale
Copy link

peppepascale commented May 1, 2024

i think i found how to activate this, had to switch to "block list" in the app:
plugins/ad-blocker/block/ then block list
then the line appears in the json and i was able to fill it like explained above.
lets see if works now

@DereC4
Copy link
Contributor

DereC4 commented May 5, 2024

This is not anything bad, but correct me if i'm wrong, back in 2023 didn't we decide to switch to "In Player" because of the RAM usage leak that was happening from the "Blocklists" option?

Did we ever fix that? I got busy with university so I had to temporarily drop this project

@JellyBrick
Copy link
Collaborator

@DereC4 Yes, that issue has been resolved.

@VeryHolyCheeeese
Copy link

If this is the definitive fix to the issue of ads not being blocked then shouldn't this be pushed in the next update?

@farsdewibs0n
Copy link

#1955 (comment) is also a viable fix. Using a link instead of a path removes the need to download the list

Note that this solution breaks search feature.

@velaton618
Copy link

This is happening on Mac as well:

Macbook air m2
Sonoma 14.4.1
Architeture: arm64

Enabled plugins:

  • All the default ones(didn't change anything)

Version: 3.3.6

@DereC4
Copy link
Contributor

DereC4 commented May 17, 2024

@DereC4 Yes, that issue has been resolved.

neat

@JellyBrick JellyBrick added fix-available A fix to the issue is available in a new version and removed help wanted Extra attention is needed labels Jun 1, 2024
@JellyBrick
Copy link
Collaborator

Fixed at 1f1efac

@JellyBrick JellyBrick unpinned this issue Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-available A fix to the issue is available in a new version
Projects
None yet
Development

No branches or pull requests