Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastDMM dosent account for macro functions #36

Open
alexkar598 opened this issue Jan 20, 2019 · 3 comments
Open

FastDMM dosent account for macro functions #36

alexkar598 opened this issue Jan 20, 2019 · 3 comments

Comments

@alexkar598
Copy link
Member

alexkar598 commented Jan 20, 2019

If a path is declared in a macro function,it isn’t put in the object tree and will crash fastdmm due to a null pointer exception if it attempts to render it in buildviewport().

This fucks up all tgstation codebases because of

@alexkar598 alexkar598 changed the title FastDMM dosent account for defines FastDMM dosent account for macro functions Jan 20, 2019
@monster860
Copy link
Contributor

the fastest solution is to make tgstation revert that change.

@bauen1
Copy link

bauen1 commented Feb 19, 2019

Here's the PR in question: tgstation/tgstation#41664
FastDMM shouldn't crash (by checking getVar for null), but you can't edit pipes then.

@HeddyLamarr
Copy link

Capture

Sorry for bumping this, but I just wanted clarification on if this issue is what is causing this error. If so has there been any progress to resolve this issue or is this project effectively on hold for the time being?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants