Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for comments and cleared flag * #9

Open
michaelede opened this issue Nov 28, 2021 · 7 comments · May be fixed by #53
Open

Support for comments and cleared flag * #9

michaelede opened this issue Nov 28, 2021 · 7 comments · May be fixed by #53
Labels
enhancement New feature or request

Comments

@michaelede
Copy link

Would it be possible to incorporate an optional comment box, and also the ability to asterisk journals that have already cleared to the bank?

@michaelede michaelede added the enhancement New feature or request label Nov 28, 2021
@tgrosinger
Copy link
Owner

Yes, both are planned in the long run.

@tgrosinger
Copy link
Owner

Comments are added in 0.3.0. Reconciliation flags are parsed and preserved, but are not visible in the UI yet.

@Signynt
Copy link

Signynt commented Jan 18, 2022

Comments are added in 0.3.0. Reconciliation flags are parsed and preserved, but are not visible in the UI yet.

Will there be a way to quickly view the comments? Currently the only way I've found is to edit the transaction. Perhaps the comment could be displayed on hover over the transaction?

@tgrosinger
Copy link
Owner

I don't yet have a plan for how to display them. I may make the table rows expandable to display them. But I'm open to other suggestions as well. Editing the transaction is also the only way to view the transaction splits right now.

@AB1908
Copy link

AB1908 commented May 21, 2023

Are reconciliation flags parsing? I get a parsing error. Using the example from ledger-cli docs:
image

@AB1908
Copy link

AB1908 commented May 22, 2023

Ah this is much more difficult to debug than I thought. It seems that after consuming a reconciled token, the nextColumn gets populated incorrectly. @tgrosinger, I'm happy to fix this but could you give me any ideas? It seems moo comes with a steep learning curve, especially since I've forgotten much about compilers.

@AB1908
Copy link

AB1908 commented May 25, 2023

I think this is the line:

transaction -> %date %ws check:? %payee %comment:? %newline expenselines
.

Once we modify this, it would also need some logic in parser.ts

@AB1908 AB1908 linked a pull request May 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants