Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma once is ignored #247

Open
Nielsbishere opened this issue Mar 23, 2023 · 2 comments
Open

Pragma once is ignored #247

Nielsbishere opened this issue Mar 23, 2023 · 2 comments

Comments

@Nielsbishere
Copy link
Contributor

#pragma once should allow duplicate includes to be ignored. Currently it'll think the same symbols are defined multiple times if one of the includes includes the same include as a different include. The error is about ambiguous symbols.

@BenSimsTantalus
Copy link

This would be great, especially because Unreal's shaders use #pragma once everywhere, and HLSL tools is now included in the latest Visual Studio previews along with improved Unreal support. I think this also causes a lot of slowdowns as it means the same files are processed many times.

@tgjones
Copy link
Owner

tgjones commented Jul 30, 2023

I agree, this would be a nice feature to add. PRs gratefully accepted 😄

TIMONz1535 added a commit to TIMONz1535/HlslTools that referenced this issue Apr 20, 2024
TIMONz1535 added a commit to TIMONz1535/HlslTools that referenced this issue Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants