Fix QTMPipeLink's usage of QProcess #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix launching of commands.
In qt4.8 there was a QProcess::start(command_line) which would automatically split the command line into args and then exec that.
In qt5 that disappeared in favor of QProcess::splitCommand and then QProcess::start--and written in a way so you can't all QProcess::start with just one string.
In qt6 that changed to start(const QString &program, const QStringList &arguments = {}, QIODeviceBase::OpenMode mode = ReadWrite), which we call as start(command_line) which did the wrong thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix launching of commands.
In qt4.8 there was a QProcess::start(command_line) which would automatically split the command line into args and then exec that.
In qt5 that disappeared in favor of QProcess::splitCommand and then QProcess::start--and written in a way so you can't call QProcess::start with just one string.
In qt6 that changed to start(const QString &program, const QStringList &arguments = {}, QIODeviceBase::OpenMode mode = ReadWrite), which we called as start(command_line) which did the wrong thing.
Fix it so that it works on Qt6.
If we wanted, we could also try to figure out the Qt version and then statically do the right thing.
As it is in this PR it will loudly fail compilation on Qt version < 6.