Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port features from libp2p test scripts #1546

Open
laurentsenta opened this issue Dec 9, 2022 · 3 comments
Open

Port features from libp2p test scripts #1546

laurentsenta opened this issue Dec 9, 2022 · 3 comments

Comments

@laurentsenta
Copy link
Contributor

laurentsenta commented Dec 9, 2022

Contributes to milestone #1514

Description

The libp2p team is simplifying how they use testground
libp2p/test-plans#85

Some are libp2p interop specific, like test generation,
But some features should be in Testground:

@MarcoPolo
Copy link

support more familiar configurations like JSON or YAML?

This doesn't matter. What matters is having a well defined configuration that can be used easily across languages. JSON, YAML, TOML isn't typed. Things fail at runtime.

The benefit of having the DSL defined in typescript is you get the schema for free. But this isn't really required. Doing something as simple as having a jsonschema defined for the configuration would also be fine.

Also, this isn't so much "Add more features to testground" as "Expose fewer features". The DSL is a small subset of the testground configuration language.

@laurentsenta
Copy link
Contributor Author

Sounds good; I updated the description.

Also, this isn't so much "Add more features to testground" as "Expose fewer features". The DSL is a small subset of the testground configuration language.

It's funny you raise the distinction, I used the term "port feature" for that reason as well! Things your script adds on top of Testground might become things we remove from Testground. Would you prefer a different name?

@laurentsenta
Copy link
Contributor Author

Two more features
see libp2p/test-plans#85 (comment) and https://gist.github.com/MarcoPolo/e4488ce57c58469298918af896ded192

  • Drop the need for test plan and test case (if artifacts are passed in, we can ignore these fields since there is no build)
  • Allow users to configure the instances in the run directly (so instead of defining a group and referencing it from the run, we define the group in each run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants