Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: build-cfg and run-cfg are almost useless without nesting #1525

Open
2 tasks
laurentsenta opened this issue Nov 15, 2022 · 0 comments
Open
2 tasks

cli: build-cfg and run-cfg are almost useless without nesting #1525

laurentsenta opened this issue Nov 15, 2022 · 0 comments
Labels
area/ux-cli Area: UX/CLI effort/days Effort: Multiple Days. exp/novice A prexisting testground user should be able to pick this up. impact/dx Impact: Developer Experience kind/improvement Kind: Improvement P3 P3: Might get fixed.

Comments

@laurentsenta
Copy link
Contributor

laurentsenta commented Nov 15, 2022

To be completed later

We use build args to pass parameters for the builder,
some / most build args are nested.

We would like to do something like:

testground run single \
    --plan="my-plan" --testcase="my-testcase" \
    --builder="docker:go" \
    --build-cfg "build_args.TEST_BROWSER_KIND=firefox"
  • what happens if you pass in build_args={"TEST_BROWSER_KIND": "firefox"}?
  • Can we merge these parameters so that "TEST_BROWSER_KIND" is not nested anymore?

cc @GlenDC (if you could add context)

@laurentsenta laurentsenta added the hint/needs-triage Hint: Needs Triage label Nov 15, 2022
@laurentsenta laurentsenta changed the title build and run-cfg are almost useless without nesting build-cfg and run-cfg are almost useless without nesting Dec 2, 2022
@laurentsenta laurentsenta changed the title build-cfg and run-cfg are almost useless without nesting cli: build-cfg and run-cfg are almost useless without nesting Dec 2, 2022
@laurentsenta laurentsenta added area/ux-cli Area: UX/CLI exp/novice A prexisting testground user should be able to pick this up. effort/days Effort: Multiple Days. P3 P3: Might get fixed. impact/dx Impact: Developer Experience kind/improvement Kind: Improvement and removed hint/needs-triage Hint: Needs Triage labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux-cli Area: UX/CLI effort/days Effort: Multiple Days. exp/novice A prexisting testground user should be able to pick this up. impact/dx Impact: Developer Experience kind/improvement Kind: Improvement P3 P3: Might get fixed.
Projects
Status: No status
Development

No branches or pull requests

1 participant