Commit d4c784f
Ranjith Muniyappa
Ignore container_name in docker-compose files instead of throwing exception
Fixes #2472
Previously, Testcontainers would throw an IllegalStateException when
parsing a docker-compose file that contained the 'container_name'
property. This prevented users from reusing their production
docker-compose files without modification.
This change modifies the behavior to log a warning instead of throwing
an exception, allowing users to use docker-compose files with
container_name properties. The container_name is simply ignored since
Testcontainers manages container naming internally.
Changes:
- ParsedDockerComposeFile: Changed validateNoContainerNameSpecified()
to log a warning instead of throwing IllegalStateException
- ParsedDockerComposeFileValidationTest: Updated tests to verify that
container_name is now ignored rather than rejected1 parent 43c6a97 commit d4c784f
File tree
2 files changed
+20
-22
lines changed- core/src
- main/java/org/testcontainers/containers
- test/java/org/testcontainers/containers
2 files changed
+20
-22
lines changedLines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
140 | 139 | | |
141 | 140 | | |
142 | 141 | | |
| |||
Lines changed: 15 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
| 27 | + | |
| 28 | + | |
32 | 29 | | |
33 | 30 | | |
34 | 31 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
40 | 38 | | |
41 | 39 | | |
42 | 40 | | |
43 | | - | |
44 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | | - | |
54 | | - | |
| 52 | + | |
| 53 | + | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
0 commit comments