Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle manifest generation does not consider generated sources #24

Open
ifedorenko opened this issue Nov 7, 2014 · 0 comments
Open

Comments

@ifedorenko
Copy link
Contributor

Consider a project that uses modello (or any other source code generation
plugin). Here is rough sequence of builder actions that occur during full
and incremental workspace builds. Note that code generation and compilation
of the generated code are performed by two different workspace builders,
MavenBuilder and JavaBuilder respectively.

  1. clean build
    • m2e/modello deletes generated sources, as expected, this is necessary to
      remove any stale generated sources
    • jdt builder removes generated .class files
  2. full workspace build (JavaBuilder)
    • there are no generated sources to compile at this point
  3. full workspace build (MavenBuilder)
    • m2e/modello is executed during 'generate-sources' phase, generated sources
      folder is added to MavenProject model but the sources compilation is
      deferred to JavaBuilder execution
    • m2e/tycho is executed but does not consider generated classes because they
      have not been compiled yet
  4. incremental build (JavaBuilder)
    • newly generated sources are compiled
  5. incremental build (MavenBuilder)
    • m2e/tycho does not run during incremental build, it'd be prohibitively
      expensive.

The short-term workaround is to change maven-bundle-plugin configuration to
NOT rely on presence of compiled generated sources classes.

The only solution I can think of is to invoke java compiler from MavenBuilder,
which will require non-trivial changes to JDT API.

ifedorenko added a commit to takari/takari-target-platform that referenced this issue Nov 15, 2014
Signed-off-by: Igor Fedorenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant