Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HsiButton should use pressed state of ExtJS button #443

Open
chrismayer opened this issue May 13, 2019 · 0 comments
Open

HsiButton should use pressed state of ExtJS button #443

chrismayer opened this issue May 13, 2019 · 0 comments

Comments

@chrismayer
Copy link
Collaborator

Currently the "HsiButton" (BasiGX.view.button.Hsi) does not use the toggle mechanism of its base class Ext.Button. Instead a custom handler function is applied which toggles a custom member variable buttonPressed. This has the effect that if the pressed state of the HsiButton is changed programatically via btn.setPressed(...) the functionality is not deactivated.

By using a toggle listener this could be fixed. The current state is available by the property pressed so no need for a custom property. This would be more intuitive and will integrate better to the whole framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant