{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":83844605,"defaultBranch":"main","name":"linux","ownerLogin":"terrelln","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-03-03T21:51:12.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6619134?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1700579099.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"40eb0e915deb4d57f90befa2f4c7781136309da0","ref":"refs/heads/zstd-for-qat","pushedAt":"2023-11-21T15:04:59.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"zstd: Backport Huffman speed improvement from upstream\n\nBackport upstream commit c7269ad [0] to improve zstd decoding speed.\n\nUpdating the kernel to zstd v1.5.5 earlier in this patch series\nregressed zstd decoding speed. This turned out to be because gcc was not\nunrolling the inner loops of the Huffman decoder which are executed a\nconstant number of times [1]. This really hurts performance, as we expect\nthis loop to be completely branch-free. This commit fixes the issue by\nunrolling the loop manually [2].\n\nThe commit fixes one more minor issue, which is to mask a variable shift\nby 0x3F. The shift was guaranteed to be less than 64, but gcc couldn't\nprove that, and emitted suboptimal code.\n\nFinally, the upstream commit added a build macro\n`HUF_DISABLE_FAST_DECODE` which is not used in the kernel, but is\nmaintained to keep a clean import from upstream.\n\nThis commit was generated from upstream signed tag v1.5.5-kernel [3] by:\n\n export ZSTD=/path/to/repo/zstd/\n export LINUX=/path/to/repo/linux/\n cd \"$ZSTD/contrib/linux-kernel\"\n git checkout v1.5.5-kernel\n make import LINUX=\"$LINUX\"\n\nI ran my benchmark & test suite before and after this commit to measure\nthe overall decompression speed benefit. It benchmarks zstd at several\ncompression levels. These benchmarks measure the total time it takes to\nread data from the compressed filesystem.\n\nComponent,\tLevel,\tRead time delta\nBtrfs ,\t 1,\t-7.0%\nBtrfs ,\t 3,\t-3.9%\nBtrfs ,\t 5,\t-4.7%\nBtrfs ,\t 7,\t-5.5%\nBtrfs ,\t 9,\t-2.4%\nSquashfs ,\t 1,\t-9.1%\n\nLink: https://github.com/facebook/zstd/commit/c7269add7eaf028ed828d9af41e732cf01993aad\nLink: https://gist.github.com/terrelln/2e14ff1fb197102a08d7823d8044978d\nLink: https://gist.github.com/terrelln/a70bde22a2abc800691fb65c21eabc2a\nLink: https://github.com/facebook/zstd/tree/v1.5.5-kernel\nSigned-off-by: Nick Terrell ","shortMessageHtmlLink":"zstd: Backport Huffman speed improvement from upstream"}},{"before":"2aa14b1ab2c41a4fe41efae80d58bb77da91f19f","after":"3f832dfb8a8eafee3cecd479d99651a64a61485a","ref":"refs/heads/zstd-next","pushedAt":"2023-11-21T00:41:04.000Z","pushType":"push","commitsCount":10000,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"zstd: fix g_debuglevel export warning\n\nThe g_debuglevel variable in debug.c is only used when DEBUGLEVEL is\ndefined to be above 2. This means by default there's no actual definition\nof this in the headers, so sparse is giving the following warning:\n\nlib/zstd/common/debug.c:24:5: warning: symbol 'g_debuglevel' was not declared. Should it be static?\n\nWe can use the same check as in the header to remove this if it isn't\ngoing to be used, silencing the warning and removing a small bit of unused\ndata.\n\nSigned-off-by: Ben Dooks \nSigned-off-by: Nick Terrell ","shortMessageHtmlLink":"zstd: fix g_debuglevel export warning"}},{"before":"11ae47d2e9a65c3e0c46add5510e5ce3186432cf","after":"77618db346455129424fadbbaec596a09feaf3bb","ref":"refs/heads/zstd-linus","pushedAt":"2023-11-15T01:01:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"zstd: Fix array-index-out-of-bounds UBSAN warning\n\nZstd used an array of length 1 to mean a flexible array for C89\ncompatibility. Switch to a C99 flexible array to fix the UBSAN warning.\n\nTested locally by booting the kernel and writing to and reading from a\nBtrFS filesystem with zstd compression enabled. I was unable to reproduce\nthe issue before the fix, however it is a trivial change.\n\nLink: https://lkml.kernel.org/r/20231012213428.1390905-1-nickrterrell@gmail.com\nReported-by: syzbot+1f2eb3e8cd123ffce499@syzkaller.appspotmail.com\nReported-by: Eric Biggers \nReported-by: Kees Cook \nSigned-off-by: Nick Terrell \nReviewed-by: Kees Cook ","shortMessageHtmlLink":"zstd: Fix array-index-out-of-bounds UBSAN warning"}},{"before":"7a697e5689309d39efe2da0c87c78bf945fd2c39","after":"11ae47d2e9a65c3e0c46add5510e5ce3186432cf","ref":"refs/heads/zstd-linus","pushedAt":"2023-11-15T01:01:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"zstd: Fix array-index-out-of-bounds UBSAN warning\n\nZstd used an array of length 1 to mean a flexible array for C89\ncompatibility. Switch to a C99 flexible array to fix the UBSAN warning.\n\nTested locally by booting the kernel and writing to and reading from a\nBtrFS filesystem with zstd compression enabled. I was unable to reproduce\nthe issue before the fix, however it is a trivial change.\n\nLink: https://lkml.kernel.org/r/20231012213428.1390905-1-nickrterrell@gmail.com\nReported-by: syzbot+1f2eb3e8cd123ffce499@syzkaller.appspotmail.com\nReported-by: Eric Biggers \nReported-by: Kees Cook \nSigned-off-by: Nick Terrell \nReviewed-by: Kees Cook ","shortMessageHtmlLink":"zstd: Fix array-index-out-of-bounds UBSAN warning"}},{"before":"f064f4e5ecb151b3fce59762075658ac6f389532","after":"7a697e5689309d39efe2da0c87c78bf945fd2c39","ref":"refs/heads/zstd-linus","pushedAt":"2023-11-15T00:47:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"zstd: Fix array-index-out-of-bounds UBSAN warning\n\nZstd used an array of length 1 to mean a flexible array for C89\ncompatibility. Switch to a C99 flexible array to fix the UBSAN warning.\n\nTested locally by booting the kernel and writing to and reading from a\nBtrFS filesystem with zstd compression enabled. I was unable to reproduce\nthe issue before the fix, however it is a trivial change.\n\nReported-by: syzbot+1f2eb3e8cd123ffce499@syzkaller.appspotmail.com\nReported-by: Eric Biggers \nReported-by: Kees Cook \nSigned-off-by: Nick Terrell \nReviewed-by: Kees Cook ","shortMessageHtmlLink":"zstd: Fix array-index-out-of-bounds UBSAN warning"}},{"before":"830b3c68c1fb1e9176028d02ef86f3cf76aa2476","after":"401644852d0b2a278811de38081be23f74b5bb04","ref":"refs/heads/main","pushedAt":"2023-10-12T21:14:58.000Z","pushType":"push","commitsCount":10000,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"Merge tag 'fs_for_v6.6-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs\n\nPull quota regression fix from Jan Kara.\n\n* tag 'fs_for_v6.6-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:\n quota: Fix slow quotaoff","shortMessageHtmlLink":"Merge tag 'fs_for_v6.6-rc6' of git://git.kernel.org/pub/scm/linux/ker…"}},{"before":"6906598f1ce93761716d780b6e3f171e13f0f4ce","after":"f064f4e5ecb151b3fce59762075658ac6f389532","ref":"refs/heads/zstd-linus","pushedAt":"2023-10-12T21:12:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"terrelln","name":"Nick Terrell","path":"/terrelln","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6619134?s=80&v=4"},"commit":{"message":"zstd: Fix array-index-out-of-bounds UBSAN warning\n\nZstd used an array of length 1 to mean a flexible array for C89\ncompatibility. Switch to a C99 flexible array to fix the UBSAN warning.\n\nTested locally by booting the kernel and writing to and reading from a\nBtrFS filesystem with zstd compression enabled. I was unable to reproduce\nthe issue before the fix, however it is a trivial change.\n\nReported-by: syzbot+1f2eb3e8cd123ffce499@syzkaller.appspotmail.com\nReported-by: Eric Biggers \nReported-by: Kees Cook \nSigned-off-by: Nick Terrell ","shortMessageHtmlLink":"zstd: Fix array-index-out-of-bounds UBSAN warning"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0yMVQxNTowNDo1OS4wMDAwMDBazwAAAAO0YCN0","startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0yMVQxNTowNDo1OS4wMDAwMDBazwAAAAO0YCN0","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMC0xMlQyMToxMjo0NS4wMDAwMDBazwAAAAOV5Mam"}},"title":"Activity · terrelln/linux"}