Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of no-delete EC2 instances #389

Closed
jeffb4 opened this issue Apr 19, 2024 · 5 comments
Closed

Allow creation of no-delete EC2 instances #389

jeffb4 opened this issue Apr 19, 2024 · 5 comments
Labels

Comments

@jeffb4
Copy link

jeffb4 commented Apr 19, 2024

Is your request related to a new offering from AWS?

This is not related to a new AWS offering

Is your request related to a problem? Please describe.

I'd like to use this very handy module for some EC2 instances that just frankly should never get deleted automatically. Examples for me are database servers - it's possible I'll need to tear them down and relaunch with automation, but the tearing down bit is likely to involve a human and a console.

Describe the solution you'd like.

The ignore_ami solution works very well, so maybe a protected_instance var for the module that creates an instance with lifecycle rules prevent_destroy and either ignore_changes all or an enumerated list of ec2 changes that would force a replacement.

Describe alternatives you've considered.

In the alternate, I could beg on my knees for Hashicorp to implement a way to add lifecycle rules programmatically to resources created in modules. Or, they could implement a way for module writers to allow lifecycle stuff to be parameterized and passed in.

Additional context

Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label May 20, 2024
@jeffb4
Copy link
Author

jeffb4 commented May 29, 2024

I guess this is technically stale, no idea if it would be accepted/rejected as a feature.

@github-actions github-actions bot removed the stale label May 30, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 30, 2024
Copy link

This issue was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant