Code Quality

Author: aschempp

.github/FUNDING.yml

@@ -0,0 +1,2 @@
+github: terminal42
+ko_fi: terminal42

.github/workflows/ci.yml

@@ -0,0 +1,11 @@
+name: CI
+
+on:
+    push: ~
+    pull_request: ~
+
+permissions: read-all
+
+jobs:
+    ci:
+        uses: 'terminal42/contao-build-tools/.github/workflows/build-tools.yml@main'

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2020 terminal42 gmbh
+Copyright (c) 2024 terminal42 gmbh
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

src/Annotation/ServiceTag.php

@@ -2,13 +2,6 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright  Copyright (c) 2020, terminal42 gmbh
- * @author     terminal42 gmbh <https://terminal42.ch>
- * @license    MIT
- * @link       http://github.com/terminal42/service-annotation-bundle
- */
-
 namespace Terminal42\ServiceAnnotationBundle\Annotation;
 
 use Doctrine\Common\Annotations\Annotation\Attribute;
@@ -32,10 +25,13 @@ class ServiceTag implements ServiceTagInterface
     protected $name;
 
     /**
-     * @var array
+     * @var array<string, string|int|float|bool>
      */
     protected $attributes = [];
 
+    /**
+     * @param array<string, string|int|float|bool> $data
+     */
     public function __construct(array $data)
     {
         $this->name = $data['value'];
@@ -50,6 +46,9 @@ public function getName(): string
         return $this->name;
     }
 
+    /**
+     * @return array<string, string|int|float|bool>
+     */
     public function getAttributes(): array
     {
         return $this->attributes;

src/Annotation/ServiceTagInterface.php

@@ -2,18 +2,14 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright  Copyright (c) 2020, terminal42 gmbh
- * @author     terminal42 gmbh <https://terminal42.ch>
- * @license    MIT
- * @link       http://github.com/terminal42/service-annotation-bundle
- */
-
 namespace Terminal42\ServiceAnnotationBundle\Annotation;
 
 interface ServiceTagInterface
 {
     public function getName(): string;
 
+    /**
+     * @return array<string, string|int|float|bool>
+     */
     public function getAttributes(): array;
 }

src/DependencyInjection/Compiler/ServiceAnnotationPass.php

@@ -2,20 +2,14 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright  Copyright (c) 2020, terminal42 gmbh
- * @author     terminal42 gmbh <https://terminal42.ch>
- * @license    MIT
- * @link       http://github.com/terminal42/service-annotation-bundle
- */
-
 namespace Terminal42\ServiceAnnotationBundle\DependencyInjection\Compiler;
 
 use Doctrine\Common\Annotations\AnnotationException;
 use Doctrine\Common\Annotations\AnnotationReader;
 use Doctrine\Common\Annotations\Reader;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\DependencyInjection\Definition;
 use Terminal42\ServiceAnnotationBundle\Annotation\ServiceTagInterface;
 
@@ -28,7 +22,7 @@ class ServiceAnnotationPass implements CompilerPassInterface
 
     public function process(ContainerBuilder $container): void
     {
-        $this->annotationReader = $container->get('annotation_reader', ContainerBuilder::NULL_ON_INVALID_REFERENCE) ?? new AnnotationReader();
+        $this->annotationReader = $container->get('annotation_reader', ContainerInterface::NULL_ON_INVALID_REFERENCE) ?? new AnnotationReader();
 
         foreach ($container->getDefinitions() as $id => $definition) {
             if ($definition->isAbstract() || $definition->isSynthetic()) {
@@ -58,6 +52,9 @@ public function process(ContainerBuilder $container): void
         }
     }
 
+    /**
+     * @param \ReflectionClass<\stdClass> $reflection
+     */
     private function parseClassAnnotations(\ReflectionClass $reflection, Definition $definition): void
     {
         try {
@@ -76,6 +73,9 @@ private function parseClassAnnotations(\ReflectionClass $reflection, Definition
         }
     }
 
+    /**
+     * @param \ReflectionClass<\stdClass> $reflection
+     */
     private function parseMethodAnnotations(\ReflectionClass $reflection, Definition $definition): void
     {
         foreach ($reflection->getMethods() as $method) {

src/Terminal42ServiceAnnotationBundle.php

@@ -2,13 +2,6 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright  Copyright (c) 2020, terminal42 gmbh
- * @author     terminal42 gmbh <https://terminal42.ch>
- * @license    MIT
- * @link       http://github.com/terminal42/service-annotation-bundle
- */
-
 namespace Terminal42\ServiceAnnotationBundle;
 
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;