Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytype type checking and annotations #138

Open
cweill opened this issue Nov 5, 2019 · 0 comments
Open

Add pytype type checking and annotations #138

cweill opened this issue Nov 5, 2019 · 0 comments
Assignees
@cweill
Labels
enhancement New feature or request

Comments

@cweill
Copy link
Contributor

cweill commented Nov 5, 2019

https://github.com/google/pytype is a static analysis tool for detecting many issues at "compile" time. Several other TensorFlow projects use pytype, and we have seen some benefits on our other projects. So we should begin adding these type checks to the adanet codebase.
@cweill cweill added the enhancement New feature or request label Nov 5, 2019
@cweill cweill self-assigned this Nov 5, 2019
@cweill cweill pinned this issue Nov 5, 2019
cweill added a commit that referenced this issue Nov 6, 2019
@cweill
Begin adding pytype support to AdaNet. #138
11147e8 
Requires some moving of direct tensorflow imports for BUILD rules.

PiperOrigin-RevId: 278864504
cweill added a commit that referenced this issue Nov 8, 2019
@cweill
Enable strict dependency checking and pytype for following modules:
21994e3 
 * core
 * distributed
 * examples

Also add `pytype` and `typing` packages to requirements.txt.

Refs #138.

PiperOrigin-RevId: 279372357
@cweill cweill mentioned this issue Nov 8, 2019
Closed
cweill added a commit that referenced this issue Nov 20, 2019
@cweill
Execute Pytype checks. | Resolves #139.
e22ddb7 
Refs #138.
Copybara import of the project:

  - 758c6ca Fix pytype complaints. by Charles Weill <[email protected]>
  - 2e12e1a Update gitignore by Charles Weill <[email protected]>
  - 6e0fffb Merge 2e12e1a into 21994... by Charles Weill <[email protected]>

PiperOrigin-RevId: 281595933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cweill cweill

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cweill