Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcd.mul1 fails on Apple M1 #528

Open
certik opened this issue May 20, 2022 · 2 comments
Open

qcd.mul1 fails on Apple M1 #528

certik opened this issue May 20, 2022 · 2 comments

Comments

@certik
Copy link

certik commented May 20, 2022

I installed Taco on Apple M1 Max using:

mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DPYTHON=ON ..

And tested using ctest. All tests pass, except:

$ ctest -R qcd.mul1 -V
UpdateCTestConfiguration  from :/Users/ondrej/repos/taco/build/DartConfiguration.tcl
UpdateCTestConfiguration  from :/Users/ondrej/repos/taco/build/DartConfiguration.tcl
Test project /Users/ondrej/repos/taco/build
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 99
    Start 99: qcd.mul1

99: Test command: /Users/ondrej/repos/taco/build/bin/taco-test "--gtest_filter=qcd.mul1"
99: Test timeout computed to be: 10000000
99: Note: Google Test filter = qcd.mul1
99: [==========] Running 1 test from 1 test case.
99: [----------] Global test environment set-up.
99: [----------] 1 test from qcd
99: [ RUN      ] qcd.mul1
99: Value of: getScalarValue(tau)
99:   Actual: 0.41212798763234709
99: Expected: 0.41212798763234737
99: [  FAILED  ] qcd.mul1 (200 ms)
99: [----------] 1 test from qcd (200 ms total)
99: 
99: [----------] Global test environment tear-down
99: [==========] 1 test from 1 test case ran. (200 ms total)
99: [  PASSED  ] 0 tests.
99: [  FAILED  ] 1 test, listed below:
99: [  FAILED  ] qcd.mul1
99: 
99:  1 FAILED TEST
1/1 Test #99: qcd.mul1 .........................***Failed    0.36 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.37 sec

The following tests FAILED:
	 99 - qcd.mul1 (Failed)
Errors while running CTest
Output from these tests are in: /Users/ondrej/repos/taco/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
@rohany
Copy link
Contributor

rohany commented May 24, 2022

I'm not sure anyone on the development team right now has an M1 mac to reproduce this issue. However, it looks like a small precision error that seems ignorable?

@certik
Copy link
Author

certik commented May 24, 2022

Yes, it seems the test should be fixed to account for these small errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants