Update Cassandra host URLs to remove the ".cluster.local" suffix #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robholland
requested changes
Jun 8, 2024
Sorry about that. |
robholland
approved these changes
Jun 14, 2024
|
Thanks for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
No longer hardcoding the cluster.local suffix on various service reference entries.
Why?
Hardcoding breaks when the cluster name isn't cluster.local.
Relative path will work unless you've done something super weird with your dns.
Checklist
Closes [Feature Request] Make Kubernetes Cluster Domain Dynamic/Configurable #469
How was this tested:
Ran the helm chart... installed. Boom.
Successfully able to resolve using relative domain names.
Any docs updates needed?
Nah.